snap: add snap manifest #3723
snap: add snap manifest #3723
Conversation
|
Hello, I'm extremely interested in this, is there any chance that this can be accepted? I have experience with snaps, and I'm willing to help if needed. |
| - https://discord.gg/ehwFt2t4wt | ||
| - https://twitter.com/DuffieldJesse | ||
| donation: | ||
| - https://github.com/jesseduffield |
There was a problem hiding this comment.
I'd just add a single URL link: https://github.com/sponsors/jesseduffield
There was a problem hiding this comment.
It's the same thing, but no problem I'll change it.
There was a problem hiding this comment.
To be clear I meant to remove the donorbox link
There was a problem hiding this comment.
Sorry, I missed the donation link. I'll fix it.
| adopt-info: lazygit | ||
| summary: simple terminal UI for git commands | ||
| description: A simple terminal UI for git commands, written in Go with the gocui library. | ||
| version: '0.42.0' |
There was a problem hiding this comment.
Is this something I should be bumping whenever I do a release or is this depending on whoever manages the snap entity?
There was a problem hiding this comment.
It's completely up to you, you can simply set the latest release tag number as the version, or you can follow something completely different.
There was a problem hiding this comment.
generally, what I do is, I set the version as the release numbers.
There was a problem hiding this comment.
I'm not quite following. What are our options? Are we able to:
- remove this line completely?
- have it dynamically set somehow
I would prefer not to have to update this file each time I release.
There was a problem hiding this comment.
Yes, we can do that too. How would you like to update it? Following the latest tag or what?
There was a problem hiding this comment.
that's right: following the latest tag of the form vX.Y.Z
| build-snaps: | ||
| - go | ||
| build-attributes: | ||
| - enable-patchelf |
There was a problem hiding this comment.
Can you please explain what this patchelf thing does.
There was a problem hiding this comment.
Because this snap will be a classic snap, there will no confinement for this snap working. So, this snap will be mounted in the usr namespace, and thus the rpaths might point to libraries from your system. patchelf is used to patch those elf-interpretors to point towards proper rpaths of the libraries shipped by the snap.
Adds the snap package manifest
go generate ./...)There is a package for lazygit in the snap store, but that's old and seems to be unmaintained. It'd be great if lazygit can be updated and upstreamed. Thanks!